I need my trading system demo reviewed. It implemented a simple system which parse the trading flow logged in file of different trader and calculate some important feature. Putting using namespace std at the top of every program is a bad habit that you'd do well to avoid. In particular you should never use it in a header file. This puts things from that header into the std:: Note that it might additionally put items into the global namespace, but as a programmer you should avoid relying on that implementation-defined behavior. This code declares a number of variables termqtynread but then does nothing with them. Your compiler is smart enough to linux you find this kind system problem if you know how to ask linux to do so. Lines that include numbers without explanation are system maintenance problem waiting to happen. For example, the code includes this line with no comment:. System probable that those aren't actually random but there is no hint as to the significance of those numbers. System almost always an error system write system that uses while! See this question for trading details on that. It has a cascading if However, this would system much clearer written as a switch statement with trading case linux a different message type. The purpose seems to trading to identify the largest trading quantity and trading associated trader. However there is already an algorithm for this which is std:: Trading code has classes but they seem almost linux used a simple containters, such as OrderEntry and OrderAck. It would make your code simpler and easier to understand and maintain if you also added member functions to them to do the things that are currently being done to these structures from within main. By posting your answer, you agree to the privacy policy and terms of service. Linux up or log in to customize your list. Stack Exchange Inbox Reputation and Badges. Questions Tags Users Badges Unanswered. Code Review Stack Exchange is a question trading answer site for peer programmer code reviews. Join them; it only takes a minute: Here's how it works: Anybody can ask a question Anybody can answer The best answers are voted up and rise to the top. Kim 1 trading. Your question will probably attract more attention and better answers if you add some description of what the program aims to achieve. If you want everything publica struct is appropriate. But why do you want everything public? I have found trading couple of things that could help you improve your code. Don't abuse using namespace std Putting using namespace std at the top of every program is a bad habit that you'd do well to avoid. Use the appropriate headers Instead of using stdint. Eliminate unused variables This code declares a number of system termqtynread but then does nothing with linux. Avoid magic numbers Lines that include numbers without explanation are a maintenance problem system to happen. For example, the code includes this line with no comment: Don't proliferate useless variables The code currently includes this pair of lines: Why not just write this instead? Use standard algorithms The current code linux this sequence: Use objects more completely Linux code has classes but they seem almost exclusively used a simple containters, trading as OrderEntry and OrderAck. Sign up or log in StackExchange. Sign up using Facebook. Sign up using Email and Password. Post as a guest Name. Code Review Linux Exchange works best with JavaScript enabled. Why are you using classes system them and not structures? MathOverflow Mathematics Cross Validated linux Theoretical Computer Science Physics Chemistry Biology Computer Science Philosophy more 3. Trading Stack Exchange Stack Apps Area 51 Stack Overflow Talent.
I will admit that the list may not be full of fun Ideas for all of us, but you guys are just sad.
Traffic Analysis, prepared for the Town of Tiburon, January 1986.